search

haskell / lsp

Haskell library for the Microsoft Language Server Protocol
364 stars 91 forks source link

Fix WorkspaceSemanticTokensRefresh type to be FromServer, not FromClient #443

Closed thomasjm closed 2 years ago

thomasjm commented 2 years ago

This method is currently miscategorized as a Method FromClient Request, but it should be a Method FromServer Request.

See here:

https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#semanticTokens_refreshRequest

michaelpj commented 2 years ago

Can you click the "allow edits from maintainers" checkbox? I can't merge master into your branch and neither can mergify.

BTW I've made a lot of progress on https://github.com/haskell/lsp/issues/421 and I'm hoping to have something usable before too long :)

thomasjm commented 2 years ago

I don't seem to have that checkbox? Just rebased onto master.

thomasjm commented 2 years ago

Thanks @michaelpj -- Great news about #421 by the way, can't wait to see it!