`lsp-test` should update document version after every editing

haskell / lsp

Haskell library for the Microsoft Language Server Protocol

360 stars 89 forks source link

`lsp-test` should update document version after every editing #474

Open July541 opened 1 year ago

July541 commented 1 year ago

Like changeDoc https://github.com/haskell/lsp/blob/7c1fcaa1073dc79e6b330b06e34d30b5d0045af6/lsp-test/src/Language/LSP/Test.hs#L471-L476

The following function should also update the version.

executeCommand
executeCodeAction
rename
formatDoc
formatRange
applyEdit

July541 commented 1 year ago

After reading the source code, I found every function above has updated the doc version, except executeCommand.

michaelpj commented 1 year ago

Hmm, looking at it it looks fine to me? even executeCommand goes via calling the appropriate server method, which should then result in an applyEdit coming back, which should be handled properly. So I'm not sure what's going on here.