search

haskell / lsp

Haskell library for the Microsoft Language Server Protocol
360 stars 89 forks source link

Metamodel.json needs to be in extra-source files #493

Closed michaelpj closed 1 year ago

michaelpj commented 1 year ago

Otherwise the metamodel component won't build.

Will need another release, I think.

joyfulmantis commented 1 year ago

Why did this problem not appear in the CI or when building it from git? Why is it a mostly stackish issue now (new-hls that depends on these packages built fine with cabal)? It would be nice if we could implement some CI check, or even some manual checking to make sure that this doesn't occur again in the future.

michaelpj commented 1 year ago

Why did this problem not appear in the CI or when building it from git?

Cabal builds from the source distribution produced with cabal sdist, not from the git checkout. I took a look but I can't see an easy way to check that the sdist builds. Possibly it is checked for package candidates and I missed it? It seems like this is a common source of broken releases...

joyfulmantis commented 1 year ago

I guess stack has an option to test the produced sdist tarball. Might be something to consider for future releases

joyfulmantis commented 1 year ago

I guess stack has an option to test the produced sdist tarball. Might be something to consider for future releases

Or I guess not, because I just tried that flag and it didn't do anything