search

haskell / lsp

Haskell library for the Microsoft Language Server Protocol
360 stars 89 forks source link

Allow aeson-2.2 #524

Closed andreasabel closed 7 months ago

andreasabel commented 8 months ago

See

Released version errors:

$ lsp-types-2.0.2.0$ cabal build --enable-tests -c 'aeson >= 2.2' --allow-newer -w ghc-9.8.1
...
src/Language/LSP/Protocol/Types/Common.hs:178:11: error: [GHC-83865]
    • Expecting one more argument to ‘KeyValue kv’
      Expected a constraint, but ‘KeyValue kv’ has kind ‘* -> Constraint’
    • In the type signature:
        (.=?) :: (KeyValue kv, ToJSON v) => String -> Maybe v -> [kv]
    |
178 | (.=?) :: (J.KeyValue kv, J.ToJSON v) => String -> Maybe v -> [kv]
    |           ^^^^^^^^^^^^^
michaelpj commented 7 months ago

Done

andreasabel commented 7 months ago

Btw, @michaelpj , maybe you want to become Stackage maintainer for hls? There is currently none, I think.

michaelpj commented 7 months ago

I'm not personally interested, since I don't use stack and I don't think lsp is that widely used. Would it be beneficial for you?

andreasabel commented 7 months ago

The thing is that as Stackage maintainer you get alerted when you should update a dependency because you would otherwise fall out of Stackage (e.g. this very issue). Otherwise, there isn't any additional "maintenance" to do you wouldn't do otherwise anyway.

Meta-comment: Why Stackage? Because it gives a quality-stamp on its packages requiring to be up-to-date with the Haskell ecosystem (with a 6 month lag); something that Hackage does not provide.