search

haskell / mtl

The Monad Transformer Library
http://www.haskell.org/haskellwiki/Monad_Transformers
Other
360 stars 63 forks source link

MonadAccum #109

Closed kozross closed 2 years ago

kozross commented 2 years ago

This defines a type class, along with a helper DerivingVia type, a bunch of instances, documentation and laws, to address the corresponding entry in #86.

This is WIP for now, as I want to add some details about the meaning of the various instances, which may not be 100% obvious to a first-time reader.

turion commented 2 years ago

I guess you're aware of https://github.com/haskell/mtl/pull/89, on which I took a break because I didn't quite get how the docs were supposed to be structured.

turion commented 2 years ago

And, I should add, I can finish #89 if that saves you work & brain capacity.

kozross commented 2 years ago

@turion At this point I'm nearly done anyway - I just have some docs to add and that's it. But thanks for offering!

emilypi commented 2 years ago

@kozross we should add @turion as a coauthor on the squash/rebased commit to master just to acknowledge their additions. We (chessai and myself) let their PR languish, and that's why it didn't go in.

kozross commented 2 years ago

@emilypi My work is clean-room, though I'm happy to add @turion into the list of authors.

kozross commented 2 years ago

@emilypi and @chessai - I wrote the docs I wanted, and addressed all the things needing addressing. I couldn't do a proper description of what the SelectT stack does, but that's because I don't even know what SelectT does in general, as @emilypi is aware.