Closed ddssff closed 5 years ago
This LGTM. @RyanGlScott any thoughts?
Oh, needs a changelog entry!
I see there is another PR with tryError.
I see there is another PR with tryError.
No worries about that. That PR I wrote is really meant to do something else, so I can rebase it on top of this later. I thought I needed tryError
to write some property but actually I don't anymore (because the property is invalid).
@ddssff the builds failed because older versions of base's Prelude do not export <$>
. i think on all GHCs before 7.10.3 you need to import Data.Functor ((<$>))
MIN_VERSION_base(4,8,0) if I'm not mistaken
yeah, something like
#if !MIN_VERSION_base(4,8,0)
import Data.Functor ((<$>))
#endif
Alternatively, we could just use fmap
, which has been exported by the Prelude for all supported versions of base. This would remove that bit of CPP. I don't have strong opinions about that, though I do prefer the least amount of CPP possible.
Oh frabjous day.
Thanks!
Fixes #60