search

haskell / mtl

The Monad Transformer Library
http://www.haskell.org/haskellwiki/Monad_Transformers
Other
362 stars 63 forks source link

Remove ListT/ErrorT-related stuff #76

Closed fumieval closed 4 years ago

fumieval commented 4 years ago

They are removed from transformers; we should remove them from mtl too (#75)

chessai commented 4 years ago

@fumieval the CPP i was referring to in #75 was for allowing for these instances with older transformers. But, I'm tempted to say that these can just be removed in the next majour version bump, without the need for CPP.

chessai commented 4 years ago

I am confused as to why github is showing that "All checks have failed", because all of them succeeded, except for HEAD (which is listed as an allowed failure). Perhaps it is to do with the strange HEAD failure, which maybe @RyanGlScott can make light of: https://travis-ci.org/github/haskell/mtl/jobs/707484624

RyanGlScott commented 4 years ago

I'm not sure what to make of HEAD-related failures either. But for what it's worth, the version of GHC HEAD that is provided at https://launchpad.net/~hvr/+archive/ubuntu/ghc (which haskell-ci uses) is quite old (around GHC 8.7 or so),. I've opted to remove the ghc-head configurations in all of my haskell-ci configs, since a HEAD that old is basically useless.

chessai commented 4 years ago

@RyanGlScott thanks, I'll probably just remove it then.

chessai commented 4 years ago

Can't get CI for the old HEAD to pass, so I'm going to just disregard it. HEAD has been removed from the .travis.yml on master.