search

haskell / network-uri

URI manipulation facilities
Other
24 stars 33 forks source link

Add Read instance to URI data type #74

Closed cbclemmer closed 11 months ago

cbclemmer commented 2 years ago

I am trying to add the URI instance to aeson like was mentioned aeson's #842, but the URI data type needs a read instance. It would be messier to create a newtype from the URI in the aeson repo so I'm just making a PR here so that it will be cleaner for the PR in aeson.

ezrakilty commented 1 year ago

I don't remember seeing this PR, I apologize. It looks good to me. Shall we reopen and merge it?

cbclemmer commented 1 year ago

@ezrakilty No worries, I was just cleaning some stuff up today. I've updated the code from master and run the tests if you want to merge it.

ezrakilty commented 1 year ago

Looks like the tests fail on version older than 7.6, because readMaybe is not present in the Text.Read package at that point. I'm thinking of just ifdef'ing out the Read instance for those versions.