haskell / network

Low-level networking interface
http://hackage.haskell.org/package/network
Other
322 stars 186 forks source link

Empty SCC annotations makes profiling tools fail #577

Closed fpringle closed 3 months ago

fpringle commented 3 months ago

The SCC annotation "" in Network.Socket.Shutdown leads to profiling output with a cost centre name. This will cause the ghc-prof profile parser to fail, which in turn affects tools depending on ghc-prof such as profiteur, profiterole and ghcprofview.

Example .prof output:

gracefulClose  Network.Socket.Shutdown   Network/Socket/Shutdown.hs:(50,1)-(78,18)       63947           0    0.0    0.0     0.0    0.0
               Network.Socket.Shutdown   Network/Socket/Shutdown.hs:60:34-48             63948           0    0.0    0.0     0.0    0.0
kazu-yamamoto commented 3 months ago

Thanks. This SCC was included accidently. I will remove it in the next version.

kazu-yamamoto commented 3 months ago

Fixed via 0505db5. This will be included the next major version (v3.2) which will be released soon.