search

haskell / primitive

This package provides various primitive memory-related operations.
Other
114 stars 58 forks source link

Redundant import in test suite #401

Closed Vekhir closed 1 year ago

Vekhir commented 1 year ago

Hi, there is a warning when building the test suite. It occurs on Arch Linux using GHC 9.0.2:

Preprocessing test suite 'test-qc' for primitive-0.8.0.0..
Building test suite 'test-qc' for primitive-0.8.0.0..
[1 of 2] Compiling PrimLaws         ( test/src/PrimLaws.hs, dist/build/test-qc/test-qc-tmp/PrimLaws.dyn_o )

test/src/PrimLaws.hs:20:1: warning: [-Wunused-imports]
    The import of ‘Control.Applicative’ is redundant
      except perhaps to import instances from ‘Control.Applicative’
    To import instances alone, use: import Control.Applicative()
   |
20 | import Control.Applicative
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^

System information:

OS: Arch Linux Kernel: Linux 6.5.3-arch1-1 GHC: 9.0.2-3 haskell-primitive: 0.8.0.0 (manually updated)

-- Vekhir

chessai commented 1 year ago

I believe that this is a holdover from a larger GHC compatibility window.

Vekhir commented 1 year ago

Yeah, in the meantime I found that Control.Applicative has been removed in 300b264669b8f4f0d7ca0b3f2458bcbf10de3f9c, so in primitive 0.9.0.0, this shouldn't be an issue. Will check out the new version once it's released.

I guess this can be closed.