search

haskell / process

Library for dealing with system processes
http://hackage.haskell.org/package/process
Other
87 stars 82 forks source link

Use POSIX_SPAWN_CLOEXEC_DEFAULT in posix_spawn.c when available #254

Closed thomasjm closed 1 year ago

thomasjm commented 2 years ago

I'm looking at improving performance when close_fds=True after encountering #189.

I noticed this could be improved on MacOS where this flag is available. Making the do_spawn_posix function handle more situations will result in fewer fallbacks to the (possibly less performant) do_spawn_fork.

I haven't tested this yet, hoping to see how it works on CI.

bgamari commented 1 year ago

Looks good, thanks @thomasjm!

thomasjm commented 1 year ago

@bgamari I don't think you meant to merge this one! The one we've been working on together is #255.

thomasjm commented 1 year ago

@bgamari hoping to get your attention here ^

bgamari commented 1 year ago

Sigh, quite right. Thanks for noticing, @thomasjm! I'll revert this and we can carry on in #255.