search

haskell / process

Library for dealing with system processes
http://hackage.haskell.org/package/process
Other
87 stars 82 forks source link

Fix compilation for wasm32-wasi #270

Closed TerrorJack closed 1 year ago

TerrorJack commented 1 year ago

This one is a rework of #240 and shouldn't break CI in this repo or any other GHC platforms now.

TerrorJack commented 1 year ago

@snoyberg Would you allow the workflow to run on this PR? Thanks :)

snoyberg commented 1 year ago

PR is passing CI, and I don't see any issues with this. @bgamari would you mind confirming that you're OK with this change landing?

TerrorJack commented 1 year ago

Ben is on holiday yet; also allow me to draft it atm, there were spurious "redundant import" warnings that turned to errors when testing in non-wasm jobs, so I also need a bit of time to look into it. Will undraft and ping again once I'm absolutely sure it doesn't break stuff on other platforms :/

TerrorJack commented 1 year ago

Ping; the current patch is good to go :)