search

haskell / process

Library for dealing with system processes
http://hackage.haskell.org/package/process
Other
87 stars 82 forks source link

Fix a non-existent macro which is unset by GHC #271

Closed TerrorJack closed 1 year ago

TerrorJack commented 1 year ago

This PR corrects an unfortunate mistake in #270. The __wasm__ macro is a builtin system macro defined by clang when targetting wasm32, however, the autoconf scripts in GHC will automatically add -undef to the CPP flags that GHC uses to invoke clang, therefore this flag is unset and will result in a link-time error for wasm32-wasi-ghc.

After this fix lands, the existing test for cross GHC will also be updated to ensure these process functions are included as a part of the test to avoid any regression here.

TerrorJack commented 1 year ago

@snoyberg It seems the pipeline isn't running even though I've got PRs merged before, would you be able to start it? Thanks :)

snoyberg commented 1 year ago

It's not giving me an option to approve starting CI, I'm not sure why.

TerrorJack commented 1 year ago

Closing in favor of #272.