search

haskell / pvp

Haskell Package Version Policy (PVP)
http://pvp.haskell.org/
38 stars 26 forks source link

Does removing a Cabal flag constitute a breaking change? #33

Open sjakobi opened 3 years ago

sjakobi commented 3 years ago

This question came up in https://github.com/haskell/bytestring/pull/371#issuecomment-787449879.

(CC @Bodigrim)

phadej commented 3 years ago

The flag in question is automatic, and doesn't affect public API (AFAIK). So removing it is not breaking change, I don't see how any consumer could break. (EDIT: compare to just adding/removing a dependency, those aren't breaking by themself)

Bodigrim commented 3 years ago

Yeah, since cabal does not mind passing non-existent package flags, I do not see this as a breaking change.

sjakobi commented 3 years ago

since cabal does not mind passing non-existent package flags

Ah, this is the bit that I was confused about. I thought that a user explicitly setting that flag might run into upgrade troubles.

If this question is something that should be documented on the website, I'd leave this issue open for now.