haskell / pvp

Haskell Package Version Policy (PVP)
http://pvp.haskell.org/
38 stars 26 forks source link

The PVP should include advice about SafeHaskell #44

Closed andreasabel closed 1 year ago

andreasabel commented 1 year ago

The PVP does at the moment not give any advice about SafeHaskell. E.g. it does not say that if you make a previously Safe module unsafe, then you need a major version bump.
Why major bump? Because then import safe statements suddenly error out, and downstream packages become unbuildable.

In the wild:

In directory-1.3.8.0, the module System.Directory is no longer Safe, as it used to be in 1.3.7.*. Thus the new release should rather have been directory-1.4.0.0. Being released as 1.3.8.0, packages using directory < 1.4 and import safe System.Directory are now broken and need a revision.

phadej commented 1 year ago

Is this duplicate of #22

phadej commented 1 year ago

Closing as duplicate of #22