Add ByteArray generation

haskell / random

Random number library

Other

53 stars 50 forks source link

Add ByteArray generation #153

Closed lehins closed 9 months ago

lehins commented 10 months ago

Fixes #142 and more.

Add compatibility with recently added ByteArray to base and fallback onto data-array-byte package for older ghc versions.

Besides this we also:

Adds functionality for filling a MutableByteArray, instead of creating an immutable ByteArray. This can help avoid allocations in some situations when array has already been preallocated.
Adds ability to generate pinned and unpinned ByteArrays.

lehins commented 10 months ago

@Bodigrim Let me know what you think about this PR if and when you have some time.

Bodigrim commented 10 months ago

@lehins overall looks great! Could you possibly organise code mentioning ByteString and ShortByteString together?

lehins commented 9 months ago

Could you possibly organise code mentioning ByteString and ShortByteString together?

@Bodigrim I am not sure I understand in which way you'd like it to be organized. All of the ByteArray/ShortByteString/ByteString functionality is together in the same part of the module. It probably doesn't look like that in the diff, because some of the ShortByteString/ByteString functionality hasn't changed and is not part of the diff.