search

haskell / security-advisories

https://haskell.github.io/security-advisories/
Other
46 stars 18 forks source link

[fix] some minor fixes #201

Closed MangoIV closed 5 months ago

MangoIV commented 6 months ago

resolves #203 resolves #202 resolves #200

hsec-tools

MangoIV commented 6 months ago

something else I was wondering. Do we really want ZonedTime? It has some really awful properties like it missing an Ord instance. What do you think about changing everything to UTCTime, @TristanCacqueray?

MangoIV commented 6 months ago

… it seems like this is an endeavour for another day, toml-parser doesn’t support it (though it should)

MangoIV commented 6 months ago

I have refactored the out of band stuff such that we can bubble up information on why it failed. This is important if git doesn't work as expected.

MangoIV commented 6 months ago

I can backport 4b and fe to the minor version if you don’t want breaking changes but I don’t know if it’d be too helpful.

telser commented 5 months ago

I believe this will resolve an issue that currently causes https://github.com/MangoIV/cabal-audit to break for me. Though @MangoIV can correct me if that is incorrect.

MangoIV commented 5 months ago

Yes @frasertweedale already knows :)

MangoIV commented 5 months ago

I have replaced ZonedTime with UTCTime; there's now not a single place where ZonedTime occurs anymore

MangoIV commented 5 months ago

how do I check if the advisories are still valid btw? :3

MangoIV commented 5 months ago

don't wanna break your stuff :3

MangoIV commented 5 months ago

thank you for your review @blackheaven @TristanCacqueray <3

blackheaven commented 5 months ago

how do I check if the advisories are still valid btw? :3

the CI handles it :)

frasertweedale commented 5 months ago

Thank you @MangoIV! Merging now.