search

haskell / statistics

A fast, high quality library for computing with statistics in Haskell.
http://hackage.haskell.org/package/statistics
BSD 2-Clause "Simplified" License
300 stars 67 forks source link

Fix some warnings (redundant imports, name shadowing) #159

Closed intricate closed 4 years ago

intricate commented 4 years ago

@Shimuuar: Is this PR of any use? :smile: Obviously it's nothing significant, but...

Shimuuar commented 4 years ago

Sorry for the delay. I was quite busy lately. I'll look at it over weekend

Shimuuar commented 4 years ago

I finally tried to do something about this PR. Problem is I'm sure it breaks build on some old GHC, but I'm unable to test it since tests are broken. So I'm leaving it hanging while I try to fix test suite

intricate commented 4 years ago

I finally tried to do something about this PR. Problem is I'm sure it breaks build on some old GHC, but I'm unable to test it since tests are broken. So I'm leaving it hanging while I try to fix test suite

Gotcha. Thanks for taking a look :smile:

Shimuuar commented 4 years ago

I cherry picked commit which fixed shadowing warning. Others quite predictably broken GHC<=7.8.

intricate commented 4 years ago

I cherry picked commit which fixed shadowing warning. Others quite predictably broken GHC<=7.8.

Thanks! I'll try building this branch on older GHC versions just to confirm and then I'll close the PR. :smiley:

Shimuuar commented 4 years ago

Here is CI run with failures https://travis-ci.org/Shimuuar/statistics/builds/632388942

intricate commented 4 years ago

Gotcha. We'll just close this PR then. Thanks for taking the time.

Shimuuar commented 4 years ago

So I dropped GHC<7.10 and this PR finally found its way into master