search

haskell / text-icu

This package provides the Haskell Data.Text.ICU library, for performing complex manipulation of Unicode text.
BSD 2-Clause "Simplified" License
47 stars 41 forks source link

Some minor ICU API updates #15

Closed ygale closed 9 years ago

ygale commented 9 years ago

Some minor tweaks that ensure continued compatibility with ICU up to the current latest version, which is 55.

The only substantive change is that the reference to ucol_equals() - which anyway was always marked as U_INTERNAL and should not have been used in the first place - was removed from the C header file. But the Eq instance for Collator was already removed some time ago, so that function anyway wasn't being used.

bos commented 9 years ago

Thanks!

ygale commented 9 years ago

Small note: spurious whitespace changes are unwelcome and make reviewing noisier :-)

Indeed, I apologize. I actually had to do some major whitespace normalization to do a guaranteed complete analysis of differences between your header file and the ones in the current version of ICU. (There were exactly 6.) Those weren't supposed to wind up in the PR, but that one slipped through.