search

haskell / time

A time library
http://hackage.haskell.org/package/time
Other
118 stars 78 forks source link

Use autogen-includes to fix local builds with v2-build #146

Closed phadej closed 3 years ago

phadej commented 3 years ago

autogen-includes is recent field, so we need to bump cabal-version. That requires changing license field to use SPDX expression syntax.

Also the parser is stricter for recent cabal-versions formats, optional comma fields (like exposed-modules) must have consistent separators (either commas between each element, or no commas at all). Adding few missing commas has smaller diff.

Bodigrim commented 3 years ago

Travis fails with Unknown fields: autogen-includes, because it is explicitly configured to use cabal <= 2.0.

AshleyYakeley commented 3 years ago

Right. @phadej, can you update the .travis file? I'm assuming this will work with GHC versions back to 8.0.2?

phadej commented 3 years ago

It will work with all GHC versions which cabal-install supports. I'd recommend to always use the most recent cabal-install available. (even with old GHCs).

That said, I have spent enough time tweaking various CIs, so I'd rather to not look into others. Feel free to push changes on top.

Bodigrim commented 3 years ago

Travis.Org is to be shut down for open-source soon. @AshleyYakeley would you like me to prepare GitHub Actions CI? I can do it tomorrow.

AshleyYakeley commented 3 years ago

Let me just fix Travis for the time being...