haskell / time

A time library
http://hackage.haskell.org/package/time
Other
118 stars 78 forks source link

Add Lift instances #234

Closed kokobd closed 1 year ago

kokobd commented 1 year ago

Closes #233

The code is not formatted with fourmolu, because existing code is not properly formatted. (I tried to call fourmolu, a lot of files changed)

AshleyYakeley commented 1 year ago

Probably better to put DeriveLift in the cabal file.

AshleyYakeley commented 1 year ago

Looks like WASM is already broken. I'll take a look.

AshleyYakeley commented 1 year ago

To format, run ./format-all -b It's a little awkward, it uses stack and my own fork of fourmolu. It changed one file, but I've added that to master now.

AshleyYakeley commented 1 year ago

I might just drop support of 8.10 (and add 9.4). It's pretty old.

AshleyYakeley commented 1 year ago

OK, don't worry about WASM, it's broken in master and I'll probably fix it after GHC 9.6 comes out.

kokobd commented 1 year ago

Probably better to put DeriveLift in the cabal file.

Thank you, I'll do this.

To format, run ./format-all -b

Ah, I was using the official fourmolu, that should be the cause.

kokobd commented 1 year ago

An import was added at the wrong position. I'll fix it later.

kokobd commented 1 year ago

This is ready for another review.

AshleyYakeley commented 1 year ago

Not sure what caused that build failure, maybe tasty-quickcheck?

AshleyYakeley commented 1 year ago

OK, build failure is in master too. I'll have a look at it.

AshleyYakeley commented 1 year ago

OK, master fixed.

AshleyYakeley commented 1 year ago

Merged, thanks!

kokobd commented 1 year ago

Cool!