haskell / vscode-haskell

VS Code extension for Haskell, powered by haskell-language-server
https://marketplace.visualstudio.com/items?itemName=haskell.haskell
Other
553 stars 90 forks source link

Activate extension for cabal files only if the used hls version supports it #418

Closed jneira closed 2 years ago

jneira commented 3 years ago
jneira commented 3 years ago

Hmm you are rigth, thanks for noting it. Could we do some change in the hls part (or the extension) to avoid those errors? To investigate. Will do a release without this change in the meanwhile.

I think we can check in the vscode plugin for the version of the hls and hls-wrapper version to launch and conditionally enable loading of cabal files.

@fendor that is a good solution but it would apply only to some version of the vscode extension and not for other editors (so they will have those errors for older hls versions if they enable them like here) So not sure if it worths look for a solution in hls, where those errors will start to be emitted.

jneira commented 3 years ago

I've reverted the tracking of .cabal files temporary in #444 (91e9738)