Remove mapFileBs to eliminate bytestring dependency

haskell / win32

Haskell support for the Win32 API

http://hackage.haskell.org/package/Win32

Other

97 stars 63 forks source link

Remove mapFileBs to eliminate bytestring dependency #167

Closed Bodigrim closed 3 years ago

Bodigrim commented 3 years ago

Closes #166.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[x] I have updated the documentation accordingly.
[x] I have not added a new Haskell dependency.
[x] I have included a changelog entry.
[x] I have not modified the version of the package in Win32.cabal.

I set up GitHub Actions in a separate branch to test my changes: https://github.com/Bodigrim/win32/actions/runs/459405515

Mistuke commented 3 years ago

Awesome thanks!

Mistuke commented 3 years ago

Do you need an early release or does the end of month releases schedule work for you?

Bodigrim commented 3 years ago

This is not immediately pressing, but I'd appreciate an earlier release, if it is not too much trouble. This is hopefully the last piece of my puzzle with bytestring.

Mistuke commented 3 years ago

Sure, no problem, I'll make the release today

Sent from my Mobile

On Tue, Jan 5, 2021, 19:54 Bodigrim notifications@github.com wrote:

This is not immediately pressing, but I'd appreciate an earlier release, if it is not too much trouble. This is hopefully the last piece of my puzzle with bytestring.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/haskell/win32/pull/167#issuecomment-754862366, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAI7OKJWJ6I5FOW5VAWRDPTSYNVAZANCNFSM4VR7QERQ .

Bodigrim commented 3 years ago

@Mistuke just a gentle reminder, in case you have time to spare.

Mistuke commented 3 years ago

Oh yeah sorry work kept me busy. Let me do it now

Sent from my Mobile

On Sun, Jan 10, 2021, 18:43 Bodigrim notifications@github.com wrote:

@Mistuke https://github.com/Mistuke just a gentle reminder, in case you have time to spare.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/haskell/win32/pull/167#issuecomment-757523595, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAI7OKIIDQGFUDRMPUV2MCDSZHYOZANCNFSM4VR7QERQ .

Bodigrim commented 3 years ago

Perfect, thanks!