Re-export base's CodePage from System.Win32.NLS when possible - Githubissues

haskell / win32

Haskell support for the Win32 API

http://hackage.haskell.org/package/Win32

Other

97 stars 62 forks source link

Re-export base's CodePage from System.Win32.NLS when possible #170

Closed RyanGlScott closed 3 years ago

RyanGlScott commented 3 years ago

Description

When building with base-4.15 or later, have System.Win32.NLS re-export the CodePage type synonym from GHC.IO.Encoding.CodePage in base.

Motivation and Context

This avoids potential import clashes, such as the one observed in RyanGlScott/code-page#5. This fixes #169.

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] My code follows the code style of this project.
[X] I have updated the documentation accordingly.
[X] I have not added a new Haskell dependency.
[X] I have included a changelog entry.
[X] I have not modified the version of the package in Win32.cabal.

Mistuke commented 3 years ago

Ah thanks! yeah the I need to consolidate the types in Base at some point..