search

haskell / win32

Haskell support for the Win32 API
http://hackage.haskell.org/package/Win32
Other
98 stars 62 forks source link

Ensure that FilePaths don't contain interior NULs #218

Closed hasufell closed 9 months ago

hasufell commented 1 year ago

Follows:

Another possible implementation is to simply switch out withTString and make it fail on any NUL char. But I'm not sure that's what we want to do. I don't have a clear picture what other APIs this can affect, but it's clear we don't want this behavior when it's about filepaths, so we specialize here.

hasufell commented 1 year ago

Are there any other modules dealing with filepath primitives?

Mistuke commented 1 year ago

Are there any other modules dealing with filepath primitives?

Not that I know off, I do intend to replace the entire library at some point with autogenerated ones so we'll have more then.

Thanks for the submission. Could you just update the comment to say it's a GHC #13660 and add a changelog entry. I assume this is urgent? I will make the release later tonight.

Mistuke commented 1 year ago

Note that process's APIs can also take FilePaths, the arguments to CreateProcess both accept full paths. So I suppose it might be worth adding a check to commandToProcess there

hasufell commented 1 year ago

I assume this is urgent? I will make the release later tonight.

Not urgent. The CLC still hasn't voted on it. It just needs to be released in lockstep with the base version containing the fix.

hasufell commented 9 months ago

Ping

Mistuke commented 9 months ago

Ah I was waiting until the CLC vote. I assume that's happened now? If so would you mind rebasing?

hasufell commented 9 months ago

The CLC vote passed: https://github.com/haskell/core-libraries-committee/issues/144#issuecomment-1489292361

I can rebase later, I'm out for dinner.

hasufell commented 9 months ago

All done

Mistuke commented 9 months ago

Thanks!

hasufell commented 9 months ago

Will you make a release?

Mistuke commented 9 months ago

Yes, when I get home on Sunday evening.

Releases are mostly automated. If the package version is increased in the cabal file it auto releases. But I want to double check some more.

Sent from my Mobile

On Sat, Dec 16, 2023, 13:44 Julian Ospald @.***> wrote:

Will you make a release?

— Reply to this email directly, view it on GitHub https://github.com/haskell/win32/pull/218#issuecomment-1858822261, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAI7OKM64AJZMZT5JNMYJODYJWQVDAVCNFSM6AAAAAAWHMZ3MWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJYHAZDEMRWGE . You are receiving this because you modified the open/close state.Message ID: @.***>