Closed lambdageek closed 7 years ago
If nothing else the present instance for JoinSemiLattice
is wrong since HM.union
is not commutative.
They most likely are, and I'm :+1: for making them the similar to Map
instances. Also HashSet
to be similar to Set
. And we need to add tests for all of them. At least as with Map
.
Maybe I'm missing something, but shouldn't the join/meet semilattice instances for
HashMap k v
be analogous toMap k v
? That is:(and similarly for Meet)