search

haskellari / postgresql-simple

Mid-level client library for accessing PostgreSQL from Haskell
Other
88 stars 46 forks source link

Implement support for postgresql 'interval' type #60

Closed amarqueslee closed 3 years ago

amarqueslee commented 3 years ago

This PR implements support for CalendarDiffTime as an analogue of the Postgresql interval type. My decision to use this type representation is based on the fact that both types claim to support bidirectional conversion to ISO 8601:2004(E) sec. 4.4.3.2.

I'll do a self-review to hopefully help ease the review process.

phadej commented 3 years ago

Don't spend time with CI (changing bounds is not good idea, and I rather fix that afterwards). Make it work where it works. Add tests.

amarqueslee commented 3 years ago

I'll shift my focus to tests, thanks.

phadej commented 3 years ago

Cleaned up in https://github.com/haskellari/postgresql-simple/pull/64. Thanks!

phadej commented 3 years ago

Released in postgresql-0.6.4

amarqueslee commented 3 years ago

Likewise, thanks for hoisting my change out of dependency hell and releasing it.