haskellari / time-compat

Compatibility package for time
BSD 3-Clause "New" or "Revised" License
2 stars 10 forks source link

time-compat-1.9.5 tests fail when built with ghc-8.6.5 #23

Open peti opened 3 years ago

peti commented 3 years ago

Citing from https://hydra.nixos.org/build/138211243:

        hourMinuteFormat
          extended:                                                               FAIL (0.02s)
            *** Failed! "00:01": expected Just 00:00:60, found Just 00:01:00 (after 82 tests and 2 shrinks):
            00:00:60
            Use --quickcheck-replay=291859 to reproduce.
nh2 commented 3 years ago

I can confirm this is still the case; here's with a different seed, and with GHC 8.10.4:

hourMinuteFormat
  extended:                                                               FAIL (0.05s)
    *** Failed! "00:01": expected Just 00:00:60, found Just 00:01:00 (after 95 tests and 2 shrinks):
    00:00:60
    Use --quickcheck-replay=502299 to reproduce.

https://buildkite.com/nh2/static-haskell-nix/builds/836#84efc3f6-b089-4199-89b5-65d78f350d8f/6-15554

nh2 commented 3 years ago

Here is an exact, pinned reproducer:

NIX_PATH=nixpkgs=https://github.com/NixOS/nixpkgs/archive/7cfaba911d8f82997c3120c8648314c23a77ed4c.tar.gz nix-build --no-out-link --expr 'with import <nixpkgs> {}; haskell.lib.overrideCabal haskellPackages.time-compat (old: { testFlags = (old.testFlags or []) ++ ["--quickcheck-replay" "502299"]; })'

        hourMinuteFormat
          extended:                                                               FAIL
            *** Failed! "00:01": expected Just 00:00:60, found Just 00:01:00 (after 95 tests and 2 shrinks):
            00:00:60
            Use --quickcheck-replay=502299 to reproduce.
          basic:                                                                  FAIL
            *** Failed! "0001": expected Just 00:00:60, found Just 00:01:00 (after 95 tests and 2 shrinks):
            00:00:60
            Use --quickcheck-replay=502299 to reproduce.
        hourFormat:                                                               FAIL
          *** Failed! "00.0166666666666666": expected Just 00:00:60, found Just 00:01:00 (after 95 tests and 2 shrinks):
          00:00:60
          Use --quickcheck-replay=502299 to reproduce.