search

haskus / packages

Haskus packages
https://haskus.org/
24 stars 11 forks source link

Fails to check doctests #46

Closed ldicarlo closed 2 months ago

ldicarlo commented 12 months ago

Currently this package prevent people from running ghcup on nixos.

I think the error message expected in DocTests changed.

I am trying to prepare a PR.

hsyl20 commented 12 months ago

It's likely due to https://github.com/haskus/packages/commit/59bf718e5dd1d8ca63046ded07e90e53f659d562

I guess the output now depends on the version of haskus-utils-types used.

ldicarlo commented 12 months ago

Do you mean that we cannot fix it? Locally, tests won't pass when running stack test. Is it expected to be different for others distributions ?

hsyl20 commented 12 months ago

If we can fix it to use the newer message, let's do it. It has been stable for several years already now.

If it's not possible I don't mind if we disable this test and convert it into unchecked documentation instead.

ldicarlo commented 12 months ago

I tried to do it but I need some guidance. I have a lot of doctests failing siren running stsck test and using import does not always work. Can you tell me how we should do?

hsyl20 commented 12 months ago

I've tested with the old stack.yaml and it passes.

stack --stack-yaml stack-8.10.yaml test haskus-utils-variant

I've tried with different compilers:

hsyl20 commented 2 months ago

I've fixed the testsuite and the doctests now pass (cf CI here)