search

hasl-sensor / integration

Swedish Public Transport Sensor (HASL). Formerly named HomeAssistant SL Sensor
https://hasl.sorlov.com
Apache License 2.0
34 stars 7 forks source link

Add filtering on lines and direction #15

Closed jadlers closed 2 years ago

jadlers commented 3 years ago

Closes #12 .

This PR implements the filtering on both lines and departures. It could be done more efficiently by first checking if the filtering should be done and then filter. However, it shouldn't be a problem since there's not all too much data to go through.

pep8speaks commented 3 years ago

Hello @jadlers! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-10-30 14:30:28 UTC
newbee112 commented 2 years ago

Hi, any progress on this?

jadlers commented 2 years ago

I've updated with a minor fix to avoid error messages, it works for me but as you can see haven't received any code review. If you're confident with pulling the repository into the configuration yourself you can do that in the mean time.