search

hasl-sensor / integration

Swedish Public Transport Sensor (HASL). Formerly named HomeAssistant SL Sensor
https://hasl.sorlov.com
Apache License 2.0
36 stars 8 forks source link

split config_entries data into `data` and `options` parts #66

Closed NecroKote closed 9 months ago

NecroKote commented 10 months ago

This allows changing all parameters other than integration type and it's id at any point

This change also contains a bump to SCHEMA_VERSION up to 4 and a migration steps for existing configurations of version 3

I've only checked this with "SL Departure" integration, so additional testing is much appreciated :)

Fixes #51

pep8speaks commented 10 months ago

Hello @NecroKote! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 273:80: E501 line too long (88 > 79 characters)

Line 44:12: E713 test for membership should be 'not in' Line 46:80: E501 line too long (90 > 79 characters) Line 48:80: E501 line too long (80 > 79 characters) Line 100:80: E501 line too long (84 > 79 characters) Line 102:80: E501 line too long (227 > 79 characters) Line 111:80: E501 line too long (84 > 79 characters)

Line 151:80: E501 line too long (81 > 79 characters) Line 152:80: E501 line too long (85 > 79 characters) Line 154:80: E501 line too long (88 > 79 characters) Line 156:80: E501 line too long (96 > 79 characters) Line 202:80: E501 line too long (84 > 79 characters)

Line 81:80: E501 line too long (81 > 79 characters) Line 82:80: E501 line too long (99 > 79 characters) Line 83:80: E501 line too long (95 > 79 characters) Line 94:80: E501 line too long (109 > 79 characters) Line 95:80: E501 line too long (91 > 79 characters) Line 97:80: E501 line too long (109 > 79 characters) Line 98:80: E501 line too long (91 > 79 characters) Line 110:80: E501 line too long (132 > 79 characters) Line 111:80: E501 line too long (130 > 79 characters) Line 126:80: E501 line too long (87 > 79 characters) Line 174:80: E501 line too long (80 > 79 characters) Line 175:80: E501 line too long (98 > 79 characters) Line 176:80: E501 line too long (97 > 79 characters) Line 186:80: E501 line too long (80 > 79 characters) Line 187:80: E501 line too long (98 > 79 characters) Line 188:80: E501 line too long (95 > 79 characters) Line 199:80: E501 line too long (133 > 79 characters) Line 200:80: E501 line too long (134 > 79 characters) Line 248:80: E501 line too long (203 > 79 characters) Line 373:80: E501 line too long (203 > 79 characters) Line 502:80: E501 line too long (97 > 79 characters) Line 519:80: E501 line too long (205 > 79 characters) Line 717:80: E501 line too long (97 > 79 characters) Line 734:80: E501 line too long (205 > 79 characters) Line 917:80: E501 line too long (97 > 79 characters) Line 934:80: E501 line too long (205 > 79 characters) Line 1120:80: E501 line too long (238 > 79 characters) Line 1224:80: E501 line too long (209 > 79 characters) Line 1325:80: E501 line too long (84 > 79 characters) Line 1327:80: E501 line too long (227 > 79 characters) Line 1336:80: E501 line too long (84 > 79 characters)