search

haslersn / any-nix-shell

fish and zsh support for the nix run and nix-shell environments of the Nix package manager
MIT License
253 stars 17 forks source link

No longer works for fish with 'nix run' #10

Closed spacekookie closed 2 years ago

spacekookie commented 3 years ago

With the last update nix run -f '<nixpkgs>' hello will no longer use the fish shell, but rather default to bash.

haslersn commented 3 years ago

Update of nix or update of any-nix-shell? Which version of Nix are you using?

BuriedInTheGround commented 3 years ago

Unfortunately, it seems that in nix run they actually hardcoded bash (see here).

sauyon commented 2 years ago

Surely that line means that simply setting SHELL=fish should be sufficient?

sersorrel commented 2 years ago

unfortunately the change to look at $SHELL was only added in nixos/nix@9d04b5da17898fd564308423bc7d10fc929efe18, which is not yet in a released nix version afaict

haslersn commented 2 years ago

@spacekookie Does #13 fix this issue for you?

drupol commented 2 years ago

@spacekookie We are waiting for feedback in order to merge #13, could you confirm it works?

spacekookie commented 2 years ago

Hey! Sorry for the long delay in response. #13 does indeed fix my problem :) Thank you