hassan-alnator / MX-Mui-TextInput

Other
1 stars 0 forks source link

Move style into cSS #1

Open Andries-Smit opened 4 years ago

Andries-Smit commented 4 years ago

Hi Hassan, Great widget!

It looks like the styling is hardcoded. https://github.com/hassan-alnator/MX-Mui-TextInput/blob/master/src/MuiInput.jsx#L6

Would it be possible to move style the (S)CSS? This would make easy for everyone to change style in the project without needing to change the widget code itself

Cheers, Andries

hassan-alnator commented 4 years ago

Hi Andries,

Thank you , this css is incapsulated with the widget and is general to make the label better looking , what are you trying to achieve ? Are you having any issues ?

If you want to add style you can add it from the mendix moduler on the style box in the properties or using the styling classes generated by mendix, if you want to dynamically add the font size for the label I can create a new property on the widget , but making it in a stylesheet will make it global using the MUI Classes system which am trying to avoid.

Am releasing a new one in a couple of days that covers multiple styles of material inputs .

Cheers, Hasan

On 26 Aug 2020, at 5:14 PM, Andries Smit notifications@github.com wrote:

Hi Hassan, Great widget!

It looks like the styling is hardcoded. https://github.com/hassan-alnator/MX-Mui-TextInput/blob/master/src/MuiInput.jsx#L6 https://github.com/hassan-alnator/MX-Mui-TextInput/blob/master/src/MuiInput.jsx#L6 Would it be possible to move style the (S)CSS? This would make easy for everyone to change style in the project without needing to change the widget code itself

Cheers, Andries

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/hassan-alnator/MX-Mui-TextInput/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABH7A4GOINB6RTTY63NSXF3SCUDDJANCNFSM4QL2AYDA.