search

hassanakbar4 / foobar-git

tractive test
0 stars 0 forks source link

send_reminder_all_open_reviews sends messages about the wrong review team #3324

Open hassanakbar4 opened 3 years ago

hassanakbar4 commented 3 years ago

component_review/ type_defect | by rjsparks@nostrum.com

The code in send_reminder_all_open_reviews grabs all ReviewerSettings that have a non-nul remind_days_open_reviews, then iterates on each returned object.

Where it should fetch the assignments for that reviewer and team associated with a particular settings object, it doesn't filter the assignments to the team, leading to mail appearing to come from team A talking about an assignment that was made from team B.

The other reminder functions should be inspected for similar errors.

Issue migrated from trac:3324 at 2021-09-27 12:28:54 +0500

hassanakbar4 commented 3 years ago

@hassanakbar4 changed status from new to accepted