search

hassanakbar4 / foobar-git

tractive test
0 stars 0 forks source link

Schedule generator does not see AD conflicts #3354

Closed hassanakbar4 closed 3 years ago

hassanakbar4 commented 3 years ago

component_meeting/*/schedule/ resolution_fixed type_defect | by jennifer@painless-security.com

The schedule generator is intended to attach a cost to AD conflicts between overlapping sessions. It frequently produces a schedule with many such conflicts but generally does not report them in its 'remaining violations' list and they only rarely show up in the violations list after each run. When they do, it's between a group and itself.

The issue is, I believe, that the session.ad value in the generator is being set to group.ad_role().pk, which refers to the role for a particular group. This will never be the same for two different groups. The session.ad value should be the pk of the associated Person

Issue migrated from trac:3354 at 2021-09-27 12:30:46 +0500

hassanakbar4 commented 3 years ago

@hassanakbar4 changed status from new to closed

hassanakbar4 commented 3 years ago

@hassanakbar4 set resolution to fixed

hassanakbar4 commented 3 years ago

@hassanakbar4 commented

Fixed in [19238]:

Find AD conflicts using AD person pk instead of role pk. Fixes #3354. Commit ready for merge.

hassanakbar4 commented 3 years ago

@hassanakbar4 commented

Fixed in [19239]:

Merged in [19238] from jennifer@painless-security.com: Find AD conflicts using AD person pk instead of role pk. Fixes #3354.