Message pane doesn't scroll

hassanakbar4 commented 9 years ago

component_MailArchive: User Interface resolution_fixed type_defect | by rcross@amsl.com

See this thread:

https://mailarchive.ietf.org/arch/search/?email_list=tools-discuss&gbt=1&index=nEAXVNczUZ85y5AEGNw1knB8Vco

I think the problem with scrolling to the bottom not triggering ajax requests is in line 147 of search.js.

if($(this).scrollTop() + $(this).innerHeight() == $(this)[0].scrollHeight) {

Using Firebug, I observed that innerHeight() can return fractional values, so the equality will not be satisfied. For example, when I put a watch on the three expressions in this condional, when the scrollbar is at the bottom , I get scrollTop() = 385 innerHeight() = 119.083333 [0] scrollHeight = 504

The jquery documentation also confirms that innerHeight() may be fractional in some cases. http://api.jquery.com/innerheight/#innerHeight1

Given this, perhaps it would be better to use something like: if($(this).scrollTop() + $(this).innerHeight() > $(this)[0].scrollHeight - 2) {

Thanks, Chris

Issue migrated from trac:1780 at 2021-09-22 16:46:36 +0500

hassanakbar4 commented 9 years ago

@hassanakbar4 edited the issue description

hassanakbar4 commented 9 years ago

@hassanakbar4 commented

Steps to reproduce:

search for some term
on search results page, Command-Plus Sign (+) to zoom one level
infinite scroll stops working
$('#msg-list').innerHeight() now returns a fractional value

hassanakbar4 commented 9 years ago

@hassanakbar4 changed status from new to closed

hassanakbar4 commented 9 years ago

@hassanakbar4 changed resolution from ` tofixed`

hassanakbar4 / mailarchive-tickets

Message pane doesn't scroll #136