mailarch static mode date/thread links lose the date

[hassanakbar4]

component_MailArchive: User Interface resolution_fixed type_defect | by johnl@iecc.com

---

In the new static mode, each page has a Date index or Thread index link to switch back and forth. But those links don't include the month so they always take you to the most recent month. This looks like someone just forgot to include the date in the link in the template.

---

Issue migrated from trac:2600 at 2021-09-22 16:54:23 +0500

[hassanakbar4]

@hassanakbar4 changed status from new to accepted

[hassanakbar4]

@hassanakbar4 changed status from accepted to assigned

[hassanakbar4]

@hassanakbar4 changed owner from rcross@amsl.com to mark@painless-security.com

[hassanakbar4]

@hassanakbar4 changed status from assigned to closed

[hassanakbar4]

@hassanakbar4 changed resolution from ` tofixed`

[hassanakbar4]

@hassanakbar4 commented

---

Fixed in [1016/mailarch]:

Include the date in the static page's date/thread links. Fixes #2600

[hassanakbar4]

@hassanakbar4 commented

---

That last commit should have included the "Ready to merge" key phrase. Please consider this for merging.

(Is there a better way for me to correct the situation where I forget that phrase in the commit message?)

[hassanakbar4]

@hassanakbar4 commented

---

Replying to [comment:4 mark@…]:

That last commit should have included the "Ready to merge" key phrase. Please consider this for merging.

(Is there a better way for me to correct the situation where I forget that phrase in the commit message?)

For commits to xml2rfc and the datatracker, merges are done by me (Henrik) and I've got scripts that pull out un-merged commits that mention "Commit ready to merge", and present them for merging. For that purpose, updating the commit log comment after the commit, using svn propedit will work. For the commit above, in your working directory:

 $ svn propedit --revprop svn:log -1016

which should open an editor and let you update the commit comment.

I don't know which workflow Ryan uses; if he simply keeps an eye on the email messages then the approach above won't work, and you'll have to send an email instead.

Ryan?

[hassanakbar4]

@hassanakbar4 commented

---

I get notification when tickets are closed. As long as the closing commit is referenced in the ticket, either by including "Fixes #" in the commit message, or manually in comments, then I have the information I need to perform the merge. Also, please include the "Commit ready for merge" key phrase in the commit message. In the future I may add some automation. Thanks.