hassanakbar4 / tractive-again

0 stars 0 forks source link

IESG Status of Items #107

Closed hassanakbar4 closed 3 years ago

hassanakbar4 commented 17 years ago

resolution_fixed type_defect | by dinara.suleymanova@neustar.biz


http://merlot.tools.ietf.org:31415/review[56]

  1. Django page is downloaded a little bit longer than the Perl one.
  2. Number of reviews sentence is not present on the Django page (although present on the Perl page)
  3. Links to drafts are not working on the Perl page.
  4. Dates are not present for most of drafts (both pages).
  5. List of documents on the Django page seems to be bigger than on the Perl page.

Thanks.

Dinara


Issue migrated from trac:107 at 2021-10-29 15:41:47 +0500

hassanakbar4 commented 17 years ago

@fenner@research.att.com edited the issue description

hassanakbar4 commented 17 years ago

@henrik@levkowetz.com changed milestone from ` toPre-release Cleanup`

hassanakbar4 commented 17 years ago

@henrik@levkowetz.com commented


1: Probably only an effect of the frames. Timing information for all pages is available and will be looked at in general later.

2: This needs checking and probably fixing

3: Wontfix bugs in the perl page

4: Same behaviour is good enough

5: Needs checking

hassanakbar4 commented 17 years ago

@henrik@levkowetz.com changed priority from n/a to major

hassanakbar4 commented 17 years ago

@henrik@levkowetz.com commented


Having a quick look at the pages, there seems to be a serious mismatch between the lists.

hassanakbar4 commented 17 years ago

@henrik@levkowetz.com changed title from Another possible defect - IESG Status of Items to IESG Status of Items

hassanakbar4 commented 17 years ago

@fenner@research.att.com changed status from new to assigned

hassanakbar4 commented 17 years ago

@fenner@research.att.com changed owner from ` tofenner@research.att.com`

hassanakbar4 commented 17 years ago

@fenner@research.att.com commented


Partial guess about what is different: the perl script looks up the document with:

     $sqlStr = qq{
         Select i.id_document_name,i.filename,i.revision,s.status_value,m.acronym
         from internet_drafts i,id_intended_status s,area_group p,acronym m
         Where i.id_document_tag = $id_document_tag
         AND i.intended_status_id = s.intended_status_id
         AND (i.b_approve_date = ''  or i.b_approve_date is NULL)
         AND i.group_acronym_id = p.group_acronym_id
         AND p.area_acronym_id = m.acronym_id
         };

On the first document that's different between perl and django versions, b_approve_date is '0000-00-00' so the perl version doesn't display it.

After adding '0000-00-00' to this "or", the first several pages are all the same. The first difference is in the middle of "Waiting for AD GoAhead", where draft-housley-tls-authz-extns has a b_approve_date set so the cgi skips it.

(Thre are some differences in "area" and "intended status", also, but I think the django version is correct each time)

I'm not sure that the b_approve_date conditional in the sql in the cgi makes any sense - we're trying to show the documents that are in the IESG datatracker, and b_approve_date doesn't stop them showing up there.

hassanakbar4 commented 17 years ago

@fenner@research.att.com commented


I removed the b_aprove_date check from my local version. The remaining differences can be summarized:

I suppose that last one is only newly exposed because before it would skip displaying I-Ds that had been published as RFC (but would display RFCs that had been approved to advance). I suspect the right thing to do here is to skip the RFC Ed Queue and RFC Published states.

diffs attached.

hassanakbar4 commented 17 years ago

@fenner@research.att.com commented


(I take it back, I didn't attach it because it is too big for this trac.)

hassanakbar4 commented 17 years ago

@fenner@research.att.com changed status from assigned to closed

hassanakbar4 commented 17 years ago

@fenner@research.att.com changed resolution from ` tofixed`

hassanakbar4 commented 17 years ago

@fenner@research.att.com commented


  1. is the "hit counter" issue
  2. the django page is correct, the perl page was missing some documents that it should have been displaying
hassanakbar4 commented 17 years ago

removed milestone (was Pre-release Cleanup)

hassanakbar4 commented 17 years ago

commented


Milestone Pre-release Cleanup deleted