hassanakbar4 / tractive-again

0 stars 0 forks source link

Comparison Review of Django "telechat/IESG" related pages #140

Closed hassanakbar4 closed 3 years ago

hassanakbar4 commented 17 years ago

resolution_fixed type_defect | by amy.vezza@neustar.biz


Comparison Review of Django "telechat/IESG" related pages:

Page: telechat/detail5b4db8a9c0076908edd11f90d0ec911eb0ebe06e

Issue: Missing the "back to index" button at the bottom of the page.

Pages: iesg/ann/detail6af2b79b1efc14ffd9ac334718c8eaa440744d37 iesg/ann/detailfe4743ad8e1c2f2e8caa8625421ceea734907c12

Issue: These pages are missing the "Recent IESG Announcements" and "Previous IESG Announcements" header sections at the top of the page.

These pages are also both missing the "back to list" button on the bottom of the page.

Page: ietf-doc/recent/

Issue: Not sure if this is really something to mark as something wrong. The dates don't match. The django page begins the list around December 18, 2006 (six months ago), but the comparison page begins the list around December 4, 3006.

Conversely, the page ietf-doc/previous/ list ends on December 13, 2006 and the comparison page ends on November 28, 2006. I can only think that there is a slight difference in how the pages are generated, and this isn't really an issue at all, but I thought I should bring it up, just in case.

Thanks!

Amy V.


Issue migrated from trac:140 at 2021-10-29 15:46:16 +0500

hassanakbar4 commented 17 years ago

@michael.lee@neustar.biz changed owner from ` tomichael.lee@neustar.biz`

hassanakbar4 commented 17 years ago

@fenner@research.att.com commented


I had already worked a little on the date issue, and fixed it, but found several more problems:

hassanakbar4 commented 17 years ago

@henrik@levkowetz.com changed milestone from ` toPre-release Cleanup`

hassanakbar4 commented 17 years ago

@michael.lee@neustar.biz changed status from new to closed

hassanakbar4 commented 17 years ago

@michael.lee@neustar.biz changed resolution from ` tofixed`

hassanakbar4 commented 17 years ago

@michael.lee@neustar.biz commented


Replying to hassanakbar4/tractive-again#140 (comment:2):

I had already worked a little on the date issue, and fixed it, but found several more problems:

  • Ballot sets are split up Fixed.

  • RFCs are not considered at all Bugs in existing system:

    • rfcs.b_approval_date is not getting set when an rfc document gets approved through IESG evaluation.
    • announcement messages listing cgis are not looking up RFCs for approval announcements.

I fixed the ID tracker so rfcs.b_approvaldate can get set. I may need to manually populate those fields for past announced RFCs. Since this is a missing piece in existing cgis, I think we can deploy the python script without this and then come back to add this. I am closing this ticket, but please reopen it if you have different thought.

Thanks,

Michael.

hassanakbar4 commented 17 years ago

removed milestone (was Pre-release Cleanup)

hassanakbar4 commented 17 years ago

commented


Milestone Pre-release Cleanup deleted