Closed hassanakbar4 closed 3 years ago
@michael.lee@neustar.biz changed owner from ` to
michael.lee@neustar.biz`
@michael.lee@neustar.biz commented
Hi Henrik,
The code has been fixed, and I don't see any of the issues below. Please review the latest copy and let me know if I can close this ticket.
Thanks, Michael.
Replying to [#148 henrik@levkowetz.com]:
Revisiting the agenda, I still find discrepancies.
- The new version has Newcomer's Training, the old one doesn't
- The old version has Afternoon Refreshment Break before the plenaries, the new one doesn't
- The new one has the plenary location merged with the plenary session name
- The new one doesn't have the same session order as the old one (minor, but makes it hard to do automatic comparisons)
@henrik@levkowetz.com commented
Mph. I shouldn't need to review, that's part of verifying that one has finished the job is in the first place. However, looking at the latest diff from the buildbot; http://merlot.tools.ietf.org/tools/ietfdb/buildbot/merlot-builder-1/builds68c39634aee60dcab59af9b495378e5ad2e56557 I still see some discrepancies:
@@ -85,0 +86,1 @@ +Roma/Vienna/Madrid SEC msec Multicast Security - CANCELLED @@ -86,1 +88,0 @@ -Roma/Vienna/Madrid SEC msec Multicast Security WG - CANCELLED
@@ -138,1 +139,0 @@ -Part 1: IAOC/IESG plenary
The first one isn't serious, but the second one is a bit unfortunate.
@michael.lee@neustar.biz changed status from new
to closed
@michael.lee@neustar.biz changed resolution from ` to
fixed`
@michael.lee@neustar.biz commented
Inline.
Replying to hassanakbar4/tractive-again#148 (comment:4):
Mph. I shouldn't need to review, that's part of verifying that one has finished the job is in the first place. However, looking at the latest diff from the buildbot; http://merlot.tools.ietf.org/tools/ietfdb/buildbot/merlot-builder-1/builds68c39634aee60dcab59af9b495378e5ad2e56557 I still see some discrepancies:
@@ -85,0 +86,1 @@ +Roma/Vienna/Madrid SEC msec Multicast Security - CANCELLED @@ -86,1 +88,0 @@ -Roma/Vienna/Madrid SEC msec Multicast Security WG - CANCELLED
@@ -138,1 +139,0 @@ -Part 1: IAOC/IESG plenary
The first one isn't serious, but the second one is a bit unfortunate. First one has been fixed. Second one is not a bug. It looks like that the first line of the agenda file (in dev env.) of Wednesday Plenary was removed. The diff is not showing any real diff (to me). I am closing this ticket.
Michael.
@henrik@levkowetz.com commented
Replying to hassanakbar4/tractive-again#148 (comment:5):
First one has been fixed. Second one is not a bug. It looks like that the first line of the agenda file (in dev env.) of Wednesday Plenary was removed.
Ah. Ok.
The diff is not showing any real diff (to me). I am closing this ticket.
Excellent.
removed milestone (was Pre-release Cleanup
)
commented
Milestone Pre-release Cleanup deleted
resolution_fixed
type_defect
| by henrik@levkowetz.comRevisiting the agenda, I still find discrepancies.
Issue migrated from trac:148 at 2021-10-29 15:51:16 +0500