misleading warning for sparse postal information

[hassanakbar4]

component_Version_3_cli_txt type_enhancement | by julian.reschke@gmx.de

---

In the attached example, one author has only city and country specified. The warning is:

foo.xml(28): Warning: Address check failed for author Πυθαγόρας ὁ Σάμιος.
foo.xml(28):    Unexpected address info: <code>: (empty)
foo.xml(28):    Unexpected address info: <street>: (empty)
foo.xml(28): Note: Recognized address elements for Greece are: <extaddr>, <street>, <code>, <city>, <country>

So something seems to insert the empty elements causing the warning message.

---

Issue migrated from trac:385 at 2021-10-20 18:30:58 +0500

[hassanakbar4]

@{"email"=>"julian.reschke@gmx.de", "name"=>nil, "username"=>nil} uploaded file foo.xml (108.5 KiB)

[hassanakbar4]

@{"email"=>"henrik@levkowetz.com", "name"=>nil, "username"=>nil} commented

---

No; I may need to tweak the error message to be clearer. What it tries to say is that a complete address would include and but there are no such elements.

[hassanakbar4]

@{"email"=>"julian.reschke@gmx.de", "name"=>nil, "username"=>nil} commented

---

That would make the warning more logical, but I don't see why this should be a warning at all. There's nothing in the specs requiring address information to be complete.

[hassanakbar4]

@{"email"=>"henrik@levkowetz.com", "name"=>nil, "username"=>nil} commented

---

And this is not an error.

Are you really trying to say that no warnings may be issued unless the specs explicitly say they must be given?

There are a lot of informative warnings which will disappear in that case.

[hassanakbar4]

@{"email"=>"julian.reschke@gmx.de", "name"=>nil, "username"=>nil} commented

---

You are right that there are reasons for warnings, even when the spec does not ask for them.

I just don't understand why this is a warning; there's nothing wrong with having sparse postal information.

At the end of the day we may want to ask the RSE for feedback on what kind of postal information should be included by an author.

[hassanakbar4]

@{"email"=>"henrik@levkowetz.com", "name"=>nil, "username"=>nil} commented

---

Sure.

[hassanakbar4]

@{"email"=>"worley@ariadne.com", "name"=>nil, "username"=>nil} commented

---

Relative to what the purpose of the message is, the wording is very strange: It asserts that and are empty (when actually they are absent), then describes that they are "recognized" for Greece (when actually they are (quasi-)mandatory).

[hassanakbar4]

@{"email"=>"pusateri@bangj.com", "name"=>nil, "username"=>nil} commented

---

I work from home and don't want to include a street address for privacy reasons. In order to get rid of the warnings in v2, I use an empty object. I would have preferred to just not have one since it is empty.

[hassanakbar4]

@{"email"=>"rjsparks@nostrum.com", "name"=>nil, "username"=>nil} _changed status from new to under_review_