search

hassanakbar4 / tractive-test

0 stars 0 forks source link

misleading warnings when <postalLine> is used #386

Open hassanakbar4 opened 5 years ago

hassanakbar4 commented 5 years ago

component_Version_3_cli_txt type_enhancement | by julian.reschke@gmx.de

In the attached example, one author's address is specified using only.

This generates the following warning:

Warning: Did not find a recognized country entry for author Julian Reschke

Issue migrated from trac:386 at 2021-10-20 18:31:04 +0500

hassanakbar4 commented 5 years ago

@{"email"=>"julian.reschke@gmx.de", "name"=>nil, "username"=>nil} uploaded file foo.xml (108.5 KiB)

hassanakbar4 commented 5 years ago

@{"email"=>"henrik@levkowetz.com", "name"=>nil, "username"=>nil} commented

Yes. Is that incorrect?

hassanakbar4 commented 5 years ago

@{"email"=>"julian.reschke@gmx.de", "name"=>nil, "username"=>nil} commented

Why is that a warning? Why does the processor care? The document fully conforms to the requirements in the specs.

hassanakbar4 commented 5 years ago

@{"email"=>"henrik@levkowetz.com", "name"=>nil, "username"=>nil} commented

You may not care. If so, ignore it. Others may care. I would.

hassanakbar4 commented 5 years ago

@{"email"=>"worley@ariadne.com", "name"=>nil, "username"=>nil} commented

It seems quite fair to say "Your input does not generate an address in the form that people usually use." Probably most of the time this is triggered, it is a mistake by the author.

hassanakbar4 commented 5 years ago

@{"email"=>"julian.reschke@gmx.de", "name"=>nil, "username"=>nil} commented

In this case it would be consequent to ask for the removal of the element.

hassanakbar4 commented 5 years ago

@{"email"=>"tony@att.com", "name"=>nil, "username"=>nil} commented

I can think of a couple cases where this would be a false positive warning: postal standards have evolved; the library may not be complete; and the author just wants to use an alternate form.

However, I agree with worley@ariadne.com that a warning would still be useful when straying into these bounds.

I know we're trying to get away from Processing Instructions, but this is the type of thing that PI were invented for: to turn on/off particular application options. Generating that warning is application-specific functionality; having a PI that says not to generate a warning seems reasonable.

hassanakbar4 commented 5 years ago

@{"email"=>"tony@att.com", "name"=>nil, "username"=>nil} changed _comment0 which not transferred by tractive

hassanakbar4 commented 4 years ago

@{"email"=>"rjsparks@nostrum.com", "name"=>nil, "username"=>nil} _changed status from new to under_review_