Blocking unicode by default causes problems for kramdown-rfc2629 users

[hassanakbar4]

component_Version 2 cli resolution_fixed type_defect | by jyasskin@chromium.org

---

kramdown-rfc2629 replaces ascii quotes with unicode quotes, which runs afoul of the new rule in xml2rfc-2.15.0 that all unicode needs to be surrounded in tags.

You can see the effect by comparing https://travis-ci.org/jyasskin/webpackage/builds/462031266 (broken) to https://travis-ci.org/jyasskin/webpackage/builds/462031448 (working).

https://github.com/cabo/kramdown-rfc2629/issues/16 discusses the kramdown-rfc2629 side of things.

---

Issue migrated from trac:387 at 2021-10-20 18:31:10 +0500

[hassanakbar4]

@{"email"=>"henrik@levkowetz.com", "name"=>nil, "username"=>nil} commented

---

Hmm. Right.

I'll add some code to convert unicode quotes back to ascii quotes. This used to happen by default earlier, but then all unicode entities were downconverted to ascii; can't do that now.

[hassanakbar4]

@{"email"=>"julian.reschke@gmx.de", "name"=>nil, "username"=>nil} commented

---

Wow.

It would really be awesome if changes like these would actually get discussion and review somewhere before making it into a release.

[hassanakbar4]

@{"email"=>"henrik@levkowetz.com", "name"=>nil, "username"=>nil} commented

---

The loss of the conversion of smart quotes and similar in the v2 renderers was not intentional.

[hassanakbar4]

@{"email"=>"henrik@levkowetz.com", "name"=>nil, "username"=>nil} commented

---

Hi Jeffrey,

I haven't managed to reproduce this here yet.

I've downloaded draft-yasskin-dispatch-web-packaging.md, used kramdown-rfc2926 to convert it to xml, and run that xml through xml2rfc with the switches the broken build shows, but without getting any exception.

Would it be possible for you to provide an xml file that triggers the issue?

[hassanakbar4]

@{"email"=>"henrik@levkowetz.com", "name"=>nil, "username"=>nil} commented

---

I've managed to reproduce this now; no action needed for the xml file.

[hassanakbar4]

@{"email"=>"henrik@levkowetz.com", "name"=>nil, "username"=>nil} changed status from new to closed

[hassanakbar4]

@{"email"=>"henrik@levkowetz.com", "name"=>nil, "username"=>nil} changed resolution from ` tofixed`

[hassanakbar4]

@{"email"=>"henrik@levkowetz.com", "name"=>nil, "username"=>nil} commented

---

Fixed in [2805]:

Reverted [2786]. Fixes issue #387.

[hassanakbar4]

@{"email"=>"henrik@levkowetz.com", "name"=>nil, "username"=>nil} commented

---

So the assumption that this was due to not downconverting smart quotes and other punctuation any more was wrong; that's working the same way it has since 2011. The bug was in now permitting non-ascii in artwork without converting it to &xNNNN; format. I've backed out that change. Permitting non-ascii in artwork is appropriate for the v3 renderers, to stay in tune with RFC7997, but the v2 renderers won't change in this respect.

[hassanakbar4]

@{"email"=>"jyasskin@chromium.org", "name"=>nil, "username"=>nil} commented

---

Sorry for the wrong guess at the root cause, and thanks for the quick fix!