hassanakbar4 / ttest

0 stars 0 forks source link

IDInternal entry with missing information generated #369

Closed hassanakbar4 closed 14 years ago

hassanakbar4 commented 14 years ago

resolution_fixed type_defect | by henrik@levkowetz.com


An IDInternal entry with a bad value for the area, and with a value for a new ballot (sequentially the next ballot ID) where the ballot was not created, recently appeared and caused 500 errors (Area matching the query not found).

Here's the stack trace which occurred when running the script which generates the all_id2.txt file:

core3:/a/www/www6s/scripts # export PYTHONPATH=/a/www/ietf-datatracker/web/
core3:/a/www/www6s/scripts # python -m ietf.idindex.generate_all_id2_txt
Traceback (most recent call last):
  File "/usr/lib/python2.5/runpy.py", line 95, in run_module
    filename, loader, alter_sys)
  File "/usr/lib/python2.5/runpy.py", line 52, in _run_module_code
    mod_name, mod_fname, mod_loader)
  File "/usr/lib/python2.5/runpy.py", line 32, in _run_code
    exec code in run_globals
  File "/a/www/ietf-datatracker[3].04/ietf/idindex/generate_all_id2_txt.py", line 38, in <module>
    print all_id2_txt().encode('utf-8'),
  File "/a/www/ietf-datatracker/web/ietf/idindex/views.py", line 134, in all_id2_txt
    data = "\n".join([all_id2_entry(id) for id in all_ids])
  File "/a/www/ietf-datatracker/web/ietf/idindex/views.py", line 94, in all_id2_entry
    area = id.idinternal.area_acronym
  File "/a/www/ietf-datatracker/web/django/db/models/fields/related.py", line 257, in __get__
    rel_obj = QuerySet(self.field.rel.to).get(**params)
  File "/a/www/ietf-datatracker/web/django/db/models/query.py", line 305, in get
    % self.model._meta.object_name)
ietf.idtracker.models.DoesNotExist: Area matching query does not exist.
core3:/a/www/www6s/scripts # 

The following database queries show part of the situation, and the repair actions taken on the database; following that there's a description from Cindy of which steps were taken on this document, which may have lead up to this situation.

mysql command trace:

mysql> select id_document_tag,area_acronym_id from id_internal where id_document_tag=17720;
+-----------------+-----------------+
| id_document_tag | area_acronym_id |
+-----------------+-----------------+
|           17720 |            1708 | 
+-----------------+-----------------+
1 row in set (0.00 sec)

mysql> update id_internal set area_acronym_id=1683 where id_document_tag=17720;
Query OK, 1 row affected (0.44 sec)
Rows matched: 1  Changed: 1  Warnings: 0

mysql> select id_document_tag,area_acronym_id,ballot_id from id_internal where id_document_tag=17720;
+-----------------+-----------------+-----------+
| id_document_tag | area_acronym_id | ballot_id |
+-----------------+-----------------+-----------+
|           17720 |            1683 |      3541 | 
+-----------------+-----------------+-----------+
1 row in set (0.00 sec)

mysql> update id_internal set ballot_id=NULL where id_document_tag=17720;
Query OK, 1 row affected, 1 warning (0.02 sec)
Rows matched: 1  Changed: 1  Warnings: 1

mysql> select id_document_tag,area_acronym_id,ballot_id from id_internal where id_document_tag=17720;
+-----------------+-----------------+-----------+
| id_document_tag | area_acronym_id | ballot_id |
+-----------------+-----------------+-----------+
|           17720 |            1683 |         0 | 
+-----------------+-----------------+-----------+
1 row in set (0.00 sec)

mysql> Bye

Cindy's description:

I used the new datatracker for this.  I don't recall the system  
throwing up any specific errors for this document while I was working  
on it; however, looking at the history now there's something that's a  
little bit wonky.  Taking these actions in the order I completed them:

 > Draft added in state Publication Requested by Cindy Morgan

   https://datatracker.ietf.org/doc/draft-ietf-bliss-shared-appearances/
   I clicked the "Add" button.

 > [Note]: 'Shida Schubert (shida@ntt-at.com) is the document shepherd.'
 > added by Cindy Morgan

   https://datatracker.ietf.org/doc/draft-ietf-bliss-shared-appearances/edit/info/
   I put this into the IESG note field and clicked the "Save" button.

 > (1.a)  Who is the Document Shepherd for this document...
   https://datatracker.ietf.org/doc/draft-ietf-bliss-shared-appearances/edit/addcomment/
   I added the proto writeup and clicked the "Add comment" button.

Strangely, there is also this entry in the history:

 > Removed from agenda for telechat by Cindy Morgan

This is weird because I never intentionally did anything with this  
draft and any agenda.  I wonder if this was triggered when I put in  
the note at https://datatracker.ietf.org/doc/draft-ietf-bliss-shared-appearances/edit/info 
  ?  I didn't touch the telechat date dropdown menu on that page, and  
the default is set to "not on agenda."  Does the system think it's  
supposed to automatically put docs on an agenda, and this message was  
triggered because I didn't select an agenda date?

I'm also not seeing anywhere in the history where a ballot for this  
document *should* have been created.  Usually that's something that  
the AD does once he's had a chance to look at the document and request  
a Last Call.

Issue migrated from trac:369 at 2021-12-13 14:47:42 +0500

hassanakbar4 commented 14 years ago

@henrik@levkowetz.com changed owner from olau@iola.com to olau@iola.dk

hassanakbar4 commented 14 years ago

@olau@iola.dk commented


I think there are three things in here:

hassanakbar4 commented 14 years ago

@henrik@levkowetz.com changed status from new to closed

hassanakbar4 commented 14 years ago

@henrik@levkowetz.com set resolution to fixed

hassanakbar4 commented 14 years ago

@henrik@levkowetz.com commented


Fixed in e830e64e7d1a5fd4e96aa27fcb5414dba421e5b4:

Merged d8d50bd4d5d39e10d4d2b865d5541ea3f6c173af from olau@. Fixes issue #369.