search

hassankhan / config

Config is a lightweight configuration file loader that supports PHP, INI, XML, JSON, and YAML files
MIT License
971 stars 136 forks source link

Support for writing Config back to a file #122

Closed markdegrootnl closed 5 years ago

markdegrootnl commented 5 years ago

Another implementation to add the ability to write a Config back to file as discussed in #107.

Most of the heavy lifting was already done by @filips123 in https://github.com/filips123/config/tree/writing however my implementation does not contain any breaking changes and comforms with the current state of the project.

filips123 commented 5 years ago

Thank you! I will review your changes this Sunday.

markdegrootnl commented 5 years ago

Is there any reason why you skipped config3 files in tests/mocks?

I think that config4 files should be renamed to config3 and tests should also be updated to use correct files.

Anyway, thank you for this PR! I will merge it when I review it completely and you fix requested changes.

Config 3 is used in another test to check the case if a file does not exist.