search

hassankhan / config

Config is a lightweight configuration file loader that supports PHP, INI, XML, JSON, and YAML files
MIT License
971 stars 136 forks source link

Add TOML support #129

Closed leocavalcante closed 4 months ago

leocavalcante commented 3 years ago

Add TOML support using yosymfony/toml lib.

DavidePastore commented 3 years ago

Hi @leocavalcante and thanks for your PR! It would be amazing if you can add that this package supports .toml file on top of README.md, where we have the "Config is a file configuration loader that supports" text.

@hassankhan, @filips123, since this package requires php >=7.1, do you think this could be a good chance to start dropping support for old PHP versions that are no more officially supported?

filips123 commented 3 years ago

do you think this could be a good chance to start dropping support for old PHP versions that are no more officially supported?

Probably yes. Based on PHP versions stats by Packagist, PHP >=7.1 is used by around 90% of Packagist users. Unfortunately there aren't any stats on package-basis, but there probably isn't much difference for here.

It could also help to modernize codebase a bit, maybe with type hints and some extra features.