search

hasscc / catlink

🐈️ Catlink scooper component for HomeAssistant
Apache License 2.0
28 stars 11 forks source link

[BUG] relapse , Deprecate hass.helpers usage (stop working in Home Assistant 2024.11) #14 #32

Closed pantan-cymk closed 1 week ago

pantan-cymk commented 1 week ago

name: elapse , Deprecate hass.helpers usage (stop working in Home Assistant 2024.11) #14 description: It looks like pull request #14 is the latest and hasn't been incorporated yet. title: "[BUG] relapse , Deprecate hass.helpers usage (stop working in Home Assistant 2024.11) #14" labels: ["bug"] assignees: []

Thanks for taking the time to fill out this bug report! Please provide as much detail as possible to help us diagnose and fix the issue.

Device

What happened?

The change that was supposed to have been made in pull request #14 has been reverted to its original state in the latest version.

Happed commit id

Relevant Log Output

Please copy and paste any relevant log output from Home Assistant.

2024-09-04 22:13:12.717 WARNING (MainThread) [homeassistant.helpers.frame] Detected that custom integration 'catlink' accesses hass.helpers.discovery. This is deprecated and will stop working in Home Assistant 2024.11, it should be updated to import functions used from discovery directly at custom_components/catlink/__init__.py, line 44: hass.helpers.discovery.async_load_platform(platform, DOMAIN, {}, config), please create a bug report at https://github.com/hasscc/catlink/issues

Checklist

By submitting this issue, you agree to follow our Code of Conduct.

milosljubenovic commented 1 week ago

Hi @pantan-cymk, my apologies for not properly passing your commit to the latest release. Thanks for your patience and again for pointing this out! This time, I've merged this to the main branch, which indeed fixed the warning.

This was not intentional to skip your fix, but we are trying to support as many devices as we can from this sweet cat-equipment vendor, so I somehow missed your fix.

Happy catting 🐱