search

hasse69 / rar2fs

FUSE file system for reading RAR archives
https://hasse69.github.io/rar2fs/
GNU General Public License v3.0
279 stars 27 forks source link

1.28.0 release archive doesn't contain man/rar2fs.1 #120

Closed Ingramz closed 5 years ago

Ingramz commented 5 years ago

When make reaches man directory, it is unable to (re)make rar2fs.1.gz.

Making all in man
make[1]: Entering directory '/work/src/rar2fs-1.28.0/man'
make[1]: *** No rule to make target 'rar2fs.1', needed by 'rar2fs.1.gz'.  Stop.
zimme commented 5 years ago

~Skipped building the man pages using make SUBDIRS=src as I don't need the man pages in my docker container.~ That didn't actually work 😝

hasse69 commented 5 years ago

Ok, I will try to update the release TAR-ball. In the mean-while, just checkout latest by using git.

hasse69 commented 5 years ago

TAR-ball should be updated now, try downloading it again.

zimme commented 5 years ago

It works! :tada:

hasse69 commented 5 years ago

Yes, it works, but it is not ok, it should not require the .gz file to be part of the distrobution. Need to check this a bit more.

zimme commented 5 years ago

It wasn't the .gz file that was needed, from what I understood it was the man/rar2fs.1 file that was missing so the compression of that file failed as it wasn't there and it only tries to compress the file if the dist has gzip installed when building.

Could be wrong though, as I didn't actually check the files. Building in docker container for the zimme/rar2fs docker image.

hasse69 commented 5 years ago

ok, I will block this release, and redo it. Sorry for the inconvenience.

hasse69 commented 5 years ago

Should be fixed now. Had to force a push (not nice, I know, but that is what I did this time).

hasse69 commented 5 years ago

Ah oh, yes... You need to download the TAR-ball again if you wish to get the same a tag v1.28.0.

zimme commented 5 years ago

Rebuilt the rar2fs container locally using no cache so it downloaded everything again and it works! :tada: Will trigger a rebuild on docker hub 👍

hasse69 commented 5 years ago

Ok, this is still broken as it does not install the .gz file anymore. I will not fix this in 1.28.0. Not sure actually how to fix it yet without adding the .gz to the distributed files and I do not wish to install both :(

EDIT: This is now fixed in master/HEAD, but the latest release still only installs the uncompressed man-page. This change/fix will be shipped with the next patch release.