search

hasse69 / rar2fs

FUSE file system for reading RAR archives
https://hasse69.github.io/rar2fs/
GNU General Public License v3.0
275 stars 27 forks source link

fix: correct ifdef check for VER_UNKNOWN #137

Closed fastcat closed 4 years ago

fastcat commented 4 years ago

Trying to build rar2fs for Debian, and thus using the version of the unrar source (and libraries) available there, I ran into a build error around VER_UNKNOWN.

That #define first showed up in 5.7.1, and is unavailable in 5.6.6, which reports RARVER_MINOR = 61

hasse69 commented 4 years ago

Thanks for the PR. An oversight from my side obviously. One minor comment though. Can you please change the commit header and remove the "fix:" tag. It is a bit superfluous.

fastcat commented 4 years ago

Fixed (for reference, it's from using https://www.conventionalcommits.org/ elsewhere)

hasse69 commented 4 years ago

Can you please make it uppercase too, Correct vs correct, or change correct to "Fix", and you get the best of both worlds :)

hasse69 commented 4 years ago

Also add yourself to AUTHORS if you like.

fastcat commented 4 years ago

Done :+1:

hasse69 commented 4 years ago

Merged. Thanks again.