search

hasse69 / rar2fs

FUSE file system for reading RAR archives
https://hasse69.github.io/rar2fs/
GNU General Public License v3.0
279 stars 27 forks source link

Publishing a 1.29.7 release #192

Closed heitbaum closed 4 months ago

heitbaum commented 4 months ago

hi @hasse69 are you going to publish a release tar.gz? Thanks in advance.

https://github.com/hasse69/rar2fs/releases/download/v1.29.7/rar2fs-1.29.7.tar.gz

hasse69 commented 4 months ago

There is a release made and I assumed the artifacts produced by the release flow was enough. So no, I had no plans of delivering additional artifacts.

heitbaum commented 4 months ago

There is a release made and I assumed the artifacts produced by the release flow was enough. So no, I had no plans of delivering additional artifacts.

Thanks. I’ll target the “automatically built source.tar.gz” instead of the “numbered file” as was previous with 1.29.6.

hartmark commented 4 months ago

Can we please have a stable link to the source tar?

I want to be able for certain have the correct tarball for building packages.

I'm maintaining the AUR package: https://aur.archlinux.org/packages/rar2fs

And the practice is that the source tarball is checksummed and compared after downloading to minimize supply attacks.

EDIT: Seems all previous releases had two tarball links https://github.com/hasse69/rar2fs/releases I can change to use the new single tarball link if we'll get the same behaviour in the future and that the link will be stable for future releases

hartmark commented 4 months ago

AUR package is now using the new tarball and I have bumped it up to use unrar 7.0.9 aswell. It seems to be working without any issues.

hasse69 commented 4 months ago

Not sure I understand? Are the artifacts provided by GitHub release flow enough or do we need to add something on top of it?

hartmark commented 4 months ago

I was a bit unclear.

The old tarball had the configure script already so I could just it without messing with autoconf. Now I have to run autoconf so I get the configure and makefiles.

See the build() function in this build file for how I build it.

https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=rar2fs

heitbaum commented 4 months ago

I was a bit unclear.

The old tarball had the configure script already so I could just it without messing with autoconf. Now I have to run autoconf so I get the configure and makefiles.

See the build() function in this build file for how I build it.

https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=rar2fs

I changed the LibreELEC build to use autotools too (which I somewhat prefer - thus the patch to autoconf)

hasse69 commented 4 months ago

I can see if we can add also the 'make dist' generated tar-ball. This was simply a test to see if the artifacts provided by GitHub was sufficient or not.

hartmark commented 4 months ago

For me the artifacts were sufficient for building the package on Arch Linux.

I also made an AUR package that will track the master branch https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=rar2fs-git